[#16792][fix] Preserve Qwen3.5-VL multimodal content order#16845
Open
fallintoplace wants to merge 1 commit into
Open
[#16792][fix] Preserve Qwen3.5-VL multimodal content order#16845fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
Opt the dense and MoE Qwen3.5-VL registrations into the existing interleaved placeholder path so OpenAI content-part ordering is retained. Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
WalkthroughQwen3.5 VLM placeholder metadata now enables interleaving for multimodal inputs. Registration tests for the dense and MoE variants verify the new metadata setting. ChangesQwen3.5 placeholder metadata
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Qwen3.5-VL uses string chat content, but its registration did not opt into the serving path that preserves ordered OpenAI content parts. Requests containing alternating text and images therefore bulk-prepended all vision placeholders, changing prompt tokenization and multimodal positions.
Enable the existing interleaved-placeholder path for the shared dense and MoE metadata. Requests without ordered content parts keep the existing BEFORE_TEXT fallback.
This addresses the placeholder-ordering part of #16792. The separate residual generation parity case described there remains out of scope.
Test Coverage
PR Checklist
Dev Engineer Review
QA Engineer Review
qwen3_5andqwen3_5_moe, adding assertions thatinterleave_placeholdersis enabled.test-db/orqa/coverage entries were identified.